cleanup

app/Concerns/HasTransactionAction.php

@@ -11,6 +11,7 @@ use App\Models\Banking\BankAccount;
 use App\Utilities\Currency\CurrencyAccessor;
 use App\Utilities\Currency\CurrencyConverter;
 use Awcodes\TableRepeater\Header;
+use Closure;
 use Filament\Forms;
 use Filament\Forms\Components\Actions\Action as FormAction;
 use Filament\Forms\Form;
@@ -21,15 +22,20 @@ trait HasTransactionAction
 {
     use HasJournalEntryActions;
 
-    protected ?TransactionType $transactionType = null;
+    protected TransactionType | Closure | null $transactionType = null;
 
-    public function type(TransactionType $type): static
+    public function type(TransactionType | Closure | null $type = null): static
     {
         $this->transactionType = $type;
 
         return $this;
     }
 
+    public function getTransactionType(): ?TransactionType
+    {
+        return $this->evaluate($this->transactionType);
+    }
+
     protected function getFormDefaultsForType(TransactionType $type): array
     {
         $commonDefaults = [

app/Filament/Actions/CreateTransactionAction.php

@@ -25,14 +25,14 @@ class CreateTransactionAction extends CreateAction
         $this->slideOver();
 
         $this->modalWidth(function (): MaxWidth {
-            return match ($this->transactionType) {
+            return match ($this->getTransactionType()) {
                 TransactionType::Journal => MaxWidth::Screen,
                 default => MaxWidth::ThreeExtraLarge,
             };
         });
 
         $this->extraModalWindowAttributes(function (): array {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 return ['class' => 'journal-transaction-modal'];
             }
 
@@ -40,19 +40,16 @@ class CreateTransactionAction extends CreateAction
         });
 
         $this->modalHeading(function (): string {
-            return match ($this->transactionType) {
-                TransactionType::Journal => 'Journal Entry',
-                TransactionType::Deposit => 'Add Income',
-                TransactionType::Withdrawal => 'Add Expense',
-                TransactionType::Transfer => 'Add Transfer',
-                default => 'Add Transaction',
+            return match ($this->getTransactionType()) {
+                TransactionType::Journal => 'Create journal entry',
+                default => 'Create transaction',
             };
         });
 
-        $this->fillForm(fn (): array => $this->getFormDefaultsForType($this->transactionType));
+        $this->fillForm(fn (): array => $this->getFormDefaultsForType($this->getTransactionType()));
 
         $this->form(function (Form $form) {
-            return match ($this->transactionType) {
+            return match ($this->getTransactionType()) {
                 TransactionType::Transfer => $this->transferForm($form),
                 TransactionType::Journal => $this->journalTransactionForm($form),
                 default => $this->transactionForm($form),
@@ -60,13 +57,13 @@ class CreateTransactionAction extends CreateAction
         });
 
         $this->afterFormFilled(function () {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $this->resetJournalEntryAmounts();
             }
         });
 
         $this->modalSubmitAction(function (StaticAction $action) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $action->disabled(! $this->isJournalEntryBalanced());
             }
 
@@ -74,13 +71,13 @@ class CreateTransactionAction extends CreateAction
         });
 
         $this->after(function (Transaction $transaction) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $transaction->updateAmountIfBalanced();
             }
         });
 
         $this->mutateFormDataUsing(function (array $data) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $data['type'] = TransactionType::Journal;
             }
 

app/Filament/Actions/EditTransactionAction.php

@@ -18,11 +18,12 @@ class EditTransactionAction extends EditAction
     {
         parent::setUp();
 
-        $this->transactionType = $this->getRecord()->type;
+        $this->type(static function (Transaction $record) {
+            return $record->type;
+        });
 
         $this->label(function () {
-            return match ($this->transactionType) {
-                TransactionType::Transfer => 'Edit transfer',
+            return match ($this->getTransactionType()) {
                 TransactionType::Journal => 'Edit journal entry',
                 default => 'Edit transaction',
             };
@@ -30,33 +31,23 @@ class EditTransactionAction extends EditAction
 
         $this->slideOver();
 
-        $this->visible(static fn (Transaction $transaction) => ! $transaction->transactionable_id);
-
         $this->modalWidth(function (): MaxWidth {
-            return match ($this->transactionType) {
+            return match ($this->getTransactionType()) {
                 TransactionType::Journal => MaxWidth::Screen,
                 default => MaxWidth::ThreeExtraLarge,
             };
         });
 
         $this->extraModalWindowAttributes(function (): array {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 return ['class' => 'journal-transaction-modal'];
             }
 
             return [];
         });
 
-        $this->modalHeading(function (): string {
-            return match ($this->transactionType) {
-                TransactionType::Journal => 'Journal Entry',
-                TransactionType::Transfer => 'Edit Transfer',
-                default => 'Edit Transaction',
-            };
-        });
-
         $this->form(function (Form $form) {
-            return match ($this->transactionType) {
+            return match ($this->getTransactionType()) {
                 TransactionType::Transfer => $this->transferForm($form),
                 TransactionType::Journal => $this->journalTransactionForm($form),
                 default => $this->transactionForm($form),
@@ -64,7 +55,7 @@ class EditTransactionAction extends EditAction
         });
 
         $this->afterFormFilled(function (Transaction $record) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $debitAmounts = $record->journalEntries->sumDebits()->getAmount();
                 $creditAmounts = $record->journalEntries->sumCredits()->getAmount();
 
@@ -74,7 +65,7 @@ class EditTransactionAction extends EditAction
         });
 
         $this->modalSubmitAction(function (StaticAction $action) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $action->disabled(! $this->isJournalEntryBalanced());
             }
 
@@ -82,7 +73,7 @@ class EditTransactionAction extends EditAction
         });
 
         $this->after(function (Transaction $transaction) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $transaction->updateAmountIfBalanced();
             }
         });

app/Filament/Company/Resources/Accounting/TransactionResource.php

@@ -172,14 +172,7 @@ class TransactionResource extends Resource
                     ->action(fn (Transaction $transaction) => $transaction->update(['reviewed' => ! $transaction->reviewed])),
                 Tables\Actions\ActionGroup::make([
                     Tables\Actions\ActionGroup::make([
-                        EditTransactionAction::make('editTransaction')
-                            ->visible(static fn (Transaction $transaction) => $transaction->type->isStandard() && ! $transaction->transactionable_id),
-                        EditTransactionAction::make('editTransfer')
-                            ->type(TransactionType::Transfer)
-                            ->visible(static fn (Transaction $transaction) => $transaction->type->isTransfer()),
-                        EditTransactionAction::make('editJournalEntry')
-                            ->type(TransactionType::Journal)
-                            ->visible(static fn (Transaction $transaction) => $transaction->type->isJournal() && ! $transaction->transactionable_id),
+                        EditTransactionAction::make(),
                         Tables\Actions\ReplicateAction::make()
                             ->excludeAttributes(['created_by', 'updated_by', 'created_at', 'updated_at'])
                             ->modal(false)

app/Filament/Tables/Actions/EditTransactionAction.php

@@ -18,35 +18,36 @@ class EditTransactionAction extends EditAction
     {
         parent::setUp();
 
-        $this->label(null);
+        $this->type(static function (Transaction $record) {
+            return $record->type;
+        });
+
+        $this->label(function () {
+            return match ($this->getTransactionType()) {
+                TransactionType::Journal => 'Edit journal entry',
+                default => 'Edit transaction',
+            };
+        });
 
         $this->slideOver();
 
         $this->modalWidth(function (): MaxWidth {
-            return match ($this->transactionType) {
+            return match ($this->getTransactionType()) {
                 TransactionType::Journal => MaxWidth::Screen,
                 default => MaxWidth::ThreeExtraLarge,
             };
         });
 
         $this->extraModalWindowAttributes(function (): array {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 return ['class' => 'journal-transaction-modal'];
             }
 
             return [];
         });
 
-        $this->modalHeading(function (): string {
-            return match ($this->transactionType) {
-                TransactionType::Journal => 'Journal Entry',
-                TransactionType::Transfer => 'Edit Transfer',
-                default => 'Edit Transaction',
-            };
-        });
-
         $this->form(function (Form $form) {
-            return match ($this->transactionType) {
+            return match ($this->getTransactionType()) {
                 TransactionType::Transfer => $this->transferForm($form),
                 TransactionType::Journal => $this->journalTransactionForm($form),
                 default => $this->transactionForm($form),
@@ -54,7 +55,7 @@ class EditTransactionAction extends EditAction
         });
 
         $this->afterFormFilled(function (Transaction $record) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $debitAmounts = $record->journalEntries->sumDebits()->getAmount();
                 $creditAmounts = $record->journalEntries->sumCredits()->getAmount();
 
@@ -64,7 +65,7 @@ class EditTransactionAction extends EditAction
         });
 
         $this->modalSubmitAction(function (StaticAction $action) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $action->disabled(! $this->isJournalEntryBalanced());
             }
 
@@ -72,7 +73,7 @@ class EditTransactionAction extends EditAction
         });
 
         $this->after(function (Transaction $transaction) {
-            if ($this->transactionType === TransactionType::Journal) {
+            if ($this->getTransactionType() === TransactionType::Journal) {
                 $transaction->updateAmountIfBalanced();
             }
         });

app/Policies/TransactionPolicy.php

@@ -0,0 +1,69 @@
+<?php
+
+namespace App\Policies;
+
+use App\Models\Accounting\Transaction;
+use App\Models\User;
+
+class TransactionPolicy
+{
+    /**
+     * Determine whether the user can view any models.
+     */
+    public function viewAny(User $user): bool
+    {
+        return true;
+    }
+
+    /**
+     * Determine whether the user can view the model.
+     */
+    public function view(User $user, Transaction $transaction): bool
+    {
+        return true;
+    }
+
+    /**
+     * Determine whether the user can create models.
+     */
+    public function create(User $user): bool
+    {
+        return true;
+    }
+
+    /**
+     * Determine whether the user can update the model.
+     */
+    public function update(User $user, Transaction $transaction): bool
+    {
+        if ($transaction->transactionable_id) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * Determine whether the user can delete the model.
+     */
+    public function delete(User $user, Transaction $transaction): bool
+    {
+        return true;
+    }
+
+    /**
+     * Determine whether the user can restore the model.
+     */
+    public function restore(User $user, Transaction $transaction): bool
+    {
+        return true;
+    }
+
+    /**
+     * Determine whether the user can permanently delete the model.
+     */
+    public function forceDelete(User $user, Transaction $transaction): bool
+    {
+        return true;
+    }
+}