wip

app/Jobs/ProcessTransactionImport.php

@@ -60,7 +60,7 @@ class ProcessTransactionImport implements ShouldQueue
         if (count($newTransactions) > 0) {
             $currentBalance = $transactionsResponse->accounts[0]->balances->current;
 
-            $transactionService->createStartingBalanceIfNeeded($this->company, $this->account, $this->bankAccount, $newTransactions, $currentBalance, $startDate);
+            $transactionService->createStartingBalanceIfNeeded($this->company, $this->bankAccount, $newTransactions, $currentBalance, $startDate);
             $transactionService->storeTransactions($this->company, $this->bankAccount, $newTransactions);
 
             $this->connectedBankAccount->update([

app/Services/TransactionService.php

@@ -18,9 +18,10 @@ use Illuminate\Support\Facades\DB;
 
 class TransactionService
 {
-    public function createStartingBalanceIfNeeded(Company $company, Account $account, BankAccount $bankAccount, array $transactions, float $currentBalance, string $startDate): void
+    public function createStartingBalanceIfNeeded(Company $company, BankAccount $bankAccount, array $transactions, float $currentBalance, string $startDate): void
     {
-        if ($account->transactions()->doesntExist()) {
+        if ($bankAccount->transactions()->doesntExist()) {
+            $account = $bankAccount->account;
             $accountSign = $account->category === AccountCategory::Asset ? 1 : -1;
 
             $sumOfTransactions = collect($transactions)->reduce(static function ($carry, $transaction) {
@@ -31,9 +32,7 @@ class TransactionService
 
             $startingBalance = bcsub($adjustedBalance, $sumOfTransactions, 2);
 
-            $currencyCode = $bankAccount->account->currency_code ?? 'USD';
-
-            $this->createStartingBalanceTransaction($company, $account, $bankAccount, (float) $startingBalance, $startDate, $currencyCode);
+            $this->createStartingBalanceTransaction($company, $bankAccount, (float) $startingBalance, $startDate);
         }
     }
 
@@ -44,7 +43,7 @@ class TransactionService
         }
     }
 
-    public function createStartingBalanceTransaction(Company $company, Account $account, BankAccount $bankAccount, float $startingBalance, string $startDate, string $currencyCode): void
+    public function createStartingBalanceTransaction(Company $company, BankAccount $bankAccount, float $startingBalance, string $startDate): void
     {
         $transactionType = $startingBalance >= 0 ? TransactionType::Deposit : TransactionType::Withdrawal;
         $accountName = $startingBalance >= 0 ? "Owner's Investment" : "Owner's Drawings";
@@ -55,6 +54,7 @@ class TransactionService
 
         $postedAt = Carbon::parse($startDate)->subDay()->toDateTimeString();
 
+        $currencyCode = $bankAccount->account->currency_code ?? 'USD';
         $amountInCents = CurrencyConverter::convertToCents(abs($startingBalance), $currencyCode);
 
         Transaction::create([