refactor: traits

app/Traits/Blamable.php

@@ -8,13 +8,15 @@ trait Blamable
 {
     public static function bootBlamable(): void
     {
-        static::creating(static function ($model) {
-            $model->created_by = Auth::check() ? Auth::id() : null;
-            $model->updated_by = Auth::check() ? Auth::id() : null;
+        $auth = Auth::check() ? Auth::id() : null;
+
+        static::creating(static function ($model) use ($auth) {
+            $model->created_by = $auth;
+            $model->updated_by = $auth;
         });
 
-        static::updating(static function ($model) {
-            $model->updated_by = Auth::check() ? Auth::id() : null;
+        static::updating(static function ($model) use ($auth) {
+            $model->updated_by = $auth;
         });
     }
 }

app/Traits/HandlesCompanyDefaultUpdate.php

@@ -1,56 +0,0 @@
-<?php
-
-namespace App\Traits;
-
-use Illuminate\Database\Eloquent\Model;
-use Illuminate\Support\Facades\Auth;
-
-trait HandlesCompanyDefaultUpdate
-{
-    abstract protected function getRelatedEntities(): array;
-
-    protected function handleRecordUpdate(Model $record, array $data): Model
-    {
-        $relatedEntities = $this->getRelatedEntities();
-
-        $existingRecord = $record::query()->where('company_id', Auth::user()->currentCompany->id)
-            ->latest()
-            ->first();
-
-        foreach ($relatedEntities as $field => $params) {
-            [$modelClass, $key, $type] = array_pad($params, 3, null);
-
-            if ($existingRecord === null || ! isset($existingRecord->{$field})) {
-                continue;
-            }
-
-            if (isset($data[$field]) && $data[$field] !== $existingRecord->{$field}) {
-                $this->updateEnabledRecord(new $modelClass, $key, $existingRecord->{$field}, $type, false);
-                $this->updateEnabledRecord(new $modelClass, $key, $data[$field], $type);
-            }
-        }
-
-        $defaults = $record::query()->where('company_id', Auth::user()->currentCompany->id)->first();
-
-        if ($defaults === null) {
-            $defaults = $record::query()->create($data);
-        } else {
-            $defaults->update($data);
-        }
-
-        return $defaults;
-    }
-
-    protected function updateEnabledRecord(Model $record, string $key, mixed $value, ?string $type = null, bool $enabled = true): void
-    {
-        $query = $record::query()->where('company_id', Auth::user()->currentCompany->id)
-            ->where('enabled', ! $enabled);
-
-        if ($type !== null) {
-            $query = $query->where('type', $type);
-        }
-
-        $query->where($key, $value)
-            ->update(compact('enabled'));
-    }
-}

app/Traits/HandlesResourceRecordCreation.php

@@ -3,73 +3,39 @@
 namespace App\Traits;
 
 use App\Models\User;
-use Filament\Support\Exceptions\Halt;
-use Illuminate\Auth\Access\AuthorizationException;
-use Illuminate\Database\Eloquent\Model;
-use Illuminate\Support\Facades\DB;
-use Illuminate\Validation\ValidationException;
-use Throwable;
+use Illuminate\Database\Eloquent\{Builder, Model};
 
 trait HandlesResourceRecordCreation
 {
-    /**
-     * @throws Halt
-     */
-    protected function handleRecordCreationWithUniqueField(array $data, Model $model, User $user, ?string $uniqueField = null, ?string $uniqueFieldValue = null): Model
+    protected function handleRecordCreationWithUniqueField(array $data, Model $model, User $user, ?string $uniqueField = null): Model
     {
-        try {
-            return DB::transaction(function () use ($data, $user, $model, $uniqueField, $uniqueFieldValue) {
-                $enabled = (bool) ($data['enabled'] ?? false);
+        $companyId = $user->currentCompany->id;
+        $shouldBeEnabled = (bool) ($data['enabled'] ?? false);
 
-                if ($enabled === true) {
-                    $this->disableExistingRecord($user->currentCompany->id, $model, $uniqueField, $uniqueFieldValue);
-                } else {
-                    $this->ensureAtLeastOneEnabled($user->currentCompany->id, $model, $enabled, $uniqueField, $uniqueFieldValue);
-                }
-
-                $data['enabled'] = $enabled;
-
-                return $model::create($data);
-            });
-        } catch (ValidationException) {
-            throw new Halt('Invalid data provided. Please check the form and try again.');
-        } catch (AuthorizationException) {
-            throw new Halt('You are not authorized to perform this action.');
-        } catch (Throwable) {
-            throw new Halt('An unexpected error occurred. Please try again.');
-        }
-    }
-
-    protected function disableExistingRecord(int $companyId, Model $model, ?string $uniqueField = null, ?string $uniqueFieldValue = null): void
-    {
-        $query = $model::query()->where('company_id', $companyId)
+        $query = $model::query()
+            ->where('company_id', $companyId)
             ->where('enabled', true);
 
-        if ($uniqueField && $uniqueFieldValue) {
-            $query->where($uniqueField, $uniqueFieldValue);
+        if ($uniqueField && array_key_exists($uniqueField, $data)) {
+            $query->where($uniqueField, $data[$uniqueField]);
         }
 
-        $existingEnabledRecord = $query->first();
+        $this->toggleRecords($query, $shouldBeEnabled);
 
-        if ($existingEnabledRecord !== null) {
-            $existingEnabledRecord->enabled = false;
-            $existingEnabledRecord->save();
-        }
+        $data['enabled'] = $shouldBeEnabled;
+        $instance = $model->newInstance($data);
+        $instance->save();
+
+        return $instance;
     }
 
-    protected function ensureAtLeastOneEnabled(int $companyId, Model $model, bool &$enabled, ?string $uniqueField = null, ?string $uniqueFieldValue = null): void
+    private function toggleRecords(Builder $query, bool &$shouldBeEnabled): void
     {
-        $query = $model::query()->where('company_id', $companyId)
-            ->where('enabled', true);
-
-        if ($uniqueField && $uniqueFieldValue) {
-            $query->where($uniqueField, $uniqueFieldValue);
-        }
-
-        $otherEnabledRecord = $query->first();
-
-        if ($otherEnabledRecord === null) {
-            $enabled = true;
+        if ($shouldBeEnabled) {
+            $existingEnabledRecord = $query->first();
+            $existingEnabledRecord?->update(['enabled' => false]);
+        } elseif ($query->doesntExist()) {
+            $shouldBeEnabled = true;
         }
     }
 }

app/Traits/HandlesResourceRecordUpdate.php

@@ -3,61 +3,38 @@
 namespace App\Traits;
 
 use App\Models\User;
-use Filament\Support\Exceptions\Halt;
-use Illuminate\Auth\Access\AuthorizationException;
 use Illuminate\Database\Eloquent\{Builder, Model};
-use Illuminate\Support\Facades\DB;
-use Illuminate\Validation\ValidationException;
-use Throwable;
 
 trait HandlesResourceRecordUpdate
 {
-    /**
-     * @throws Halt
-     */
     protected function handleRecordUpdateWithUniqueField(Model $record, array $data, User $user, ?string $uniqueField = null): Model
     {
-        try {
-            return DB::transaction(function () use ($user, $uniqueField, $record, $data) {
-                $companyId = $user->currentCompany->id;
-                $oldValue = $uniqueField ? $record->{$uniqueField} : null;
-                $newValue = $uniqueField ? $data[$uniqueField] : null;
-                $enabled = (bool) ($data['enabled'] ?? false);
+        $companyId = $user->currentCompany->id;
+        $oldValue = $uniqueField ? $record->{$uniqueField} : null;
+        $newValue = $uniqueField ? $data[$uniqueField] : null;
+        $enabled = (bool) ($data['enabled'] ?? false);
 
-                if ($oldValue !== $newValue && $record->enabled) {
-                    $this->toggleRecord($companyId, $record, $uniqueField, $oldValue, false, true);
-                }
+        if ($oldValue !== $newValue && $record->getAttribute('enabled')) {
+            $this->toggleRecord($companyId, $record, $uniqueField, $oldValue, false, true);
+        }
 
-                if ($enabled === true) {
-                    $this->toggleRecord($companyId, $record, $uniqueField, $newValue, true, false);
-                } elseif ($enabled === false) {
-                    $this->ensureAtLeastOneEnabled($companyId, $record, $uniqueField, $newValue, $enabled);
-                }
+        if ($enabled === true) {
+            $this->toggleRecord($companyId, $record, $uniqueField, $newValue, true, false);
+        } elseif ($enabled === false) {
+            $this->ensureAtLeastOneEnabled($companyId, $record, $uniqueField, $newValue, $enabled);
+        }
 
-                $data['enabled'] = $enabled;
+        $data['enabled'] = $enabled;
 
-                return tap($record)->update($data);
-            });
-        } catch (ValidationException) {
-            throw new Halt('Invalid data provided. Please check the form and try again.');
-        } catch (AuthorizationException) {
-            throw new Halt('You are not authorized to perform this action.');
-        } catch (Throwable) {
-            throw new Halt('An unexpected error occurred. Please try again.');
-        }
+        return tap($record)->update($data);
     }
 
     protected function toggleRecord(int $companyId, Model $record, ?string $uniqueField, $value, bool $enabled, bool $newStatus): void
     {
         $query = $this->buildQuery($companyId, $record, $uniqueField, $value, $enabled);
 
-        if ($newStatus) {
-            $otherRecord = $query->first();
-
-            if ($otherRecord) {
-                $otherRecord->enabled = true;
-                $otherRecord->save();
-            }
+        if ($newStatus && ($otherRecord = $query->first())) {
+            $otherRecord->update(['enabled' => true]);
         } else {
             $query->update(['enabled' => false]);
         }
@@ -65,24 +42,16 @@ trait HandlesResourceRecordUpdate
 
     protected function buildQuery(int $companyId, Model $record, ?string $uniqueField, $value, bool $enabled): Builder
     {
-        $query = $record::query()->where('company_id', $companyId)
-            ->where('id', '!=', $record->id)
-            ->where('enabled', $enabled);
-
-        if ($uniqueField) {
-            $query->where($uniqueField, $value);
-        }
-
-        return $query;
+        return $record::query()
+            ->where('company_id', $companyId)
+            ->where('id', '!=', $record->getKey())
+            ->where('enabled', $enabled)
+            ->when($uniqueField, static fn ($q) => $q->where($uniqueField, $value));
     }
 
     protected function ensureAtLeastOneEnabled(int $companyId, Model $record, ?string $uniqueField, $value, bool &$enabled): void
     {
         $query = $this->buildQuery($companyId, $record, $uniqueField, $value, true);
-        $enabledCount = $query->count();
-
-        if ($enabledCount === 0) {
-            $enabled = true;
-        }
+        $enabled = $query->exists() ? $enabled : true;
     }
 }