wip

app/Filament/Company/Resources/Sales/InvoiceResource.php

@@ -413,7 +413,6 @@ class InvoiceResource extends Resource
                             ->url(static fn (Invoice $record) => Pages\ViewInvoice::getUrl(['record' => $record])),
                         Invoice::getReplicateAction(Tables\Actions\ReplicateAction::class),
                         Invoice::getApproveDraftAction(Tables\Actions\Action::class),
-                        Invoice::getBlockedApproveAction(Tables\Actions\Action::class),
                         Invoice::getMarkAsSentAction(Tables\Actions\Action::class),
                         Tables\Actions\Action::make('recordPayment')
                             ->label(fn (Invoice $record) => $record->status === InvoiceStatus::Overpaid ? 'Refund Overpayment' : 'Record Payment')

app/Filament/Company/Resources/Sales/InvoiceResource/Pages/ViewInvoice.php

@@ -5,6 +5,7 @@ namespace App\Filament\Company\Resources\Sales\InvoiceResource\Pages;
 use App\Enums\Accounting\DocumentType;
 use App\Filament\Company\Resources\Sales\ClientResource;
 use App\Filament\Company\Resources\Sales\InvoiceResource;
+use App\Filament\Infolists\Components\BannerEntry;
 use App\Filament\Infolists\Components\DocumentPreview;
 use App\Models\Accounting\Invoice;
 use Filament\Actions;
@@ -17,6 +18,7 @@ use Filament\Support\Enums\FontWeight;
 use Filament\Support\Enums\IconPosition;
 use Filament\Support\Enums\IconSize;
 use Filament\Support\Enums\MaxWidth;
+use Illuminate\Support\HtmlString;
 
 class ViewInvoice extends ViewRecord
 {
@@ -40,7 +42,6 @@ class ViewInvoice extends ViewRecord
             Actions\ActionGroup::make([
                 Actions\ActionGroup::make([
                     Invoice::getApproveDraftAction(),
-                    Invoice::getBlockedApproveAction(),
                     Invoice::getMarkAsSentAction(),
                     Invoice::getPrintDocumentAction(),
                     Invoice::getReplicateAction(),
@@ -61,6 +62,31 @@ class ViewInvoice extends ViewRecord
     {
         return $infolist
             ->schema([
+                BannerEntry::make('inactiveAdjustments')
+                    ->label('Inactive adjustments')
+                    ->warning()
+                    ->icon('heroicon-o-exclamation-triangle')
+                    ->visible(fn (Invoice $record) => $record->hasInactiveAdjustments() && $record->canBeApproved())
+                    ->columnSpanFull()
+                    ->description(function (Invoice $record) {
+                        $inactiveAdjustments = collect();
+
+                        foreach ($record->lineItems as $lineItem) {
+                            foreach ($lineItem->adjustments as $adjustment) {
+                                if ($adjustment->isInactive() && $inactiveAdjustments->doesntContain($adjustment->name)) {
+                                    $inactiveAdjustments->push($adjustment->name);
+                                }
+                            }
+                        }
+
+                        $adjustmentsList = $inactiveAdjustments->map(static function ($name) {
+                            return "<span class='font-medium'>{$name}</span>";
+                        })->join(', ');
+
+                        $output = "<p class='text-sm'>This invoice contains inactive adjustments that need to be addressed before approval: {$adjustmentsList}</p>";
+
+                        return new HtmlString($output);
+                    }),
                 Section::make('Invoice Details')
                     ->columns(4)
                     ->schema([

app/Models/Accounting/Document.php

@@ -35,6 +35,15 @@ abstract class Document extends Model
         return $this->lineItems()->exists();
     }
 
+    public function hasInactiveAdjustments(): bool
+    {
+        return $this->lineItems->contains(function (DocumentLineItem $lineItem) {
+            return $lineItem->adjustments->contains(function (Adjustment $adjustment) {
+                return $adjustment->isInactive();
+            });
+        });
+    }
+
     public static function getPrintDocumentAction(string $action = Action::class): MountableAction
     {
         return $action::make('printPdf')

app/Models/Accounting/Invoice.php

@@ -23,6 +23,7 @@ use Filament\Actions\Action;
 use Filament\Actions\MountableAction;
 use Filament\Actions\ReplicateAction;
 use Filament\Actions\StaticAction;
+use Filament\Notifications\Notification;
 use Filament\Support\Enums\Alignment;
 use Illuminate\Database\Eloquent\Attributes\CollectedBy;
 use Illuminate\Database\Eloquent\Attributes\ObservedBy;
@@ -34,6 +35,7 @@ use Illuminate\Database\Eloquent\Relations\MorphMany;
 use Illuminate\Database\Eloquent\Relations\MorphOne;
 use Illuminate\Support\Carbon;
 use Illuminate\Support\HtmlString;
+use Livewire\Component;
 
 #[CollectedBy(DocumentCollection::class)]
 #[ObservedBy(InvoiceObserver::class)]
@@ -461,15 +463,6 @@ class Invoice extends Document
         return CurrencyConverter::convertCentsToFormatSimple($convertedCents);
     }
 
-    public function hasInactiveAdjustments(): bool
-    {
-        return $this->lineItems->contains(function (DocumentLineItem $lineItem) {
-            return $lineItem->adjustments->contains(function (Adjustment $adjustment) {
-                return $adjustment->isInactive();
-            });
-        });
-    }
-
     // TODO: Potentially handle this another way
     public static function getBlockedApproveAction(string $action = Action::class): MountableAction
     {
@@ -515,15 +508,30 @@ class Invoice extends Document
             ->label('Approve')
             ->icon('heroicon-m-check-circle')
             ->visible(function (self $record) {
-                return $record->canBeApproved() && ! $record->hasInactiveAdjustments();
+                return $record->canBeApproved();
             })
             ->requiresConfirmation()
             ->databaseTransaction()
             ->successNotificationTitle('Invoice approved')
-            ->action(function (self $record, MountableAction $action) {
-                $record->approveDraft();
+            ->action(function (self $record, MountableAction $action, Component $livewire) {
+                if ($record->hasInactiveAdjustments()) {
+                    $isViewPage = $livewire instanceof InvoiceResource\Pages\ViewInvoice;
+
+                    if (! $isViewPage) {
+                        redirect(InvoiceResource\Pages\ViewInvoice::getUrl(['record' => $record->id]));
+                    } else {
+                        Notification::make()
+                            ->warning()
+                            ->title('Cannot approve invoice')
+                            ->body('This invoice has inactive adjustments that must be addressed first.')
+                            ->persistent()
+                            ->send();
+                    }
+                } else {
+                    $record->approveDraft();
 
-                $action->success();
+                    $action->success();
+                }
             });
     }